Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datahub] OGC API custom URL Generation using ogc-client #882

Merged
merged 3 commits into from
May 23, 2024
Merged

[Datahub] OGC API custom URL Generation using ogc-client #882

merged 3 commits into from
May 23, 2024

Conversation

ronitjadhav
Copy link
Collaborator

Description

This PR updates the method for generating custom OGC API URL, now utilizing ogc-client. Additionally, it refactors the code to enhance its quality.

  • Using getCollectionItemsUrl from ogc-client library to generate the custom URL
  • Refactored record-api-form component to simplify endpoint handling.
  • Created a single instance of the endpoint and reused it across methods.
  • Improved logic to handle both OGC API and WFS protocols with fewer conditional checks.
  • Fixed tests to check the new way URLs are built.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2024 •
edited
Loading

Affected libs: ui-elements, feature-notifications, feature-catalog, feature-record, feature-router, feature-editor, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, demo, datahub, webcomponents, map-viewer, search, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented May 22, 2024 •
edited
Loading

Coverage Status

coverage: 84.372% (+1.4%) from 82.992%
when pulling a568867 on DH_OGC_API_CUSTOM_URL
into 8224939 on main.

@ronitjadhav ronitjadhav force-pushed the DH_OGC_API_CUSTOM_URL branch 2 times, most recently from 81b4127 to 3045d5f Compare May 22, 2024 12:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2024 •
edited
Loading

📷 Screenshots are here!

@ronitjadhav ronitjadhav force-pushed the DH_OGC_API_CUSTOM_URL branch 5 times, most recently from 6042fac to 76ae593 Compare May 22, 2024 15:39
@ronitjadhav ronitjadhav force-pushed the DH_OGC_API_CUSTOM_URL branch 3 times, most recently from 9622db9 to c285f2a Compare May 23, 2024 11:00
@ronitjadhav ronitjadhav force-pushed the DH_OGC_API_CUSTOM_URL branch from c285f2a to a3cd6cf Compare May 23, 2024 11:21
jahow
jahow approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ronitjadhav ronitjadhav merged commit 2b3239d into main May 23, 2024
9 checks passed
@ronitjadhav ronitjadhav deleted the DH_OGC_API_CUSTOM_URL branch May 23, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronitjadhav @coveralls @jahow